Skip to content

Fix #7700: Export forwarders of inline methods are themselves inline #7702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 9, 2019

No description provided.

@biboudis
Copy link
Contributor

biboudis commented Dec 10, 2019

LGTM.

@odersky I have a small question: despite that inline methods are not overridden by definition, some users may write code like the one below. Does it make sense to emit a warning for cases like these?

package test

class Macros
  inline def meth(): String = ???

object Meth
  private val macros = new Macros() { override def meth(): String = ??? }
  export macros.meth

@odersky
Copy link
Contributor Author

odersky commented Dec 10, 2019

You mean, generally warn when an inline method is overridden, or just for exports?

@biboudis
Copy link
Contributor

You mean, generally warn when an inline method is overridden, or just for exports?

I was thinking about both occasions, yes.

@odersky odersky closed this Dec 10, 2019
@odersky odersky reopened this Dec 11, 2019
@odersky odersky merged commit 9bad8bc into scala:master Dec 11, 2019
@odersky odersky deleted the gfix-#7700 branch December 11, 2019 17:50
@morgen-peschke
Copy link

Thanks @odersky :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants